-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/2293 Character Annex Report #2339
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Visit the preview URL for this PR (updated for commit aaf42fc): https://jac-admin-develop--pr2339-feature-2293-charact-1mneeeti.web.app (expires Wed, 10 Apr 2024 10:35:12 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 4e92cf51659207b0ae3509dc5c40edde50edfec0 |
HalcyonJAC
requested review from
NormaJAC,
tomlovesgithub,
drieJAC,
KoWeiJAC,
warrensearle,
nickaddy and
Franceswog
March 11, 2024 11:23
Franceswog
approved these changes
Mar 11, 2024
drieJAC
approved these changes
Mar 11, 2024
tomlovesgithub
approved these changes
Mar 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's included?
Closes #2293.
Note: This PR requires the changes in digital-platform: Feature/admin 2293 Character Annex Report.
Who should test?
✅ Product owner
✅ Developers
✅ UTG
How to test?
Example exercise: https://jac-admin-develop--pr2339-feature-2293-charact-1mneeeti.web.app/exercise/aDxEqK36807d0Nhpugo3/reports/character-issues
Risk - how likely is this to impact other areas?
🟢 No risk - this is a self-contained piece of work
Additional context
Demo:
Screen.Recording.2024-03-08.at.14.50.56.mov
Related permissions
Have permissions been considered for this functionality?
PREVIEW:DEVELOP
can be OFF, DEVELOP or STAGING