Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add new ethnic options #2343

Merged
merged 1 commit into from
Mar 8, 2024

Conversation

KoWeiJAC
Copy link
Contributor

@KoWeiJAC KoWeiJAC commented Mar 6, 2024

What's included?

Closes #2305

Who should test?

✅ Product owner
✅ Developers
✅ UTG

How to test?

Screenshot 2024-03-06 at 16 23 46 Screenshot 2024-03-06 at 16 24 40 Screenshot 2024-03-07 at 10 27 53

Risk - how likely is this to impact other areas?

🟢 No risk - this is a self-contained piece of work

Additional context

Include screen grabs, video demo, notes etc.

Related permissions

Have permissions been considered for this functionality?

  • No permission changes required
  • Permissions have been added / updated. Details:

PREVIEW:DEVELOP
can be OFF, DEVELOP or STAGING

Copy link

github-actions bot commented Mar 6, 2024

Visit the preview URL for this PR (updated for commit 0c7671c):

https://jac-admin-develop--pr2343-feat-2305-align-cand-4my1zlmx.web.app

(expires Sat, 06 Apr 2024 17:20:01 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 4e92cf51659207b0ae3509dc5c40edde50edfec0

@KoWeiJAC KoWeiJAC marked this pull request as ready for review March 6, 2024 16:28
@KoWeiJAC KoWeiJAC requested review from a team as code owners March 6, 2024 16:28
@KoWeiJAC KoWeiJAC requested a review from HalcyonJAC March 6, 2024 16:28
@nickaddy
Copy link
Contributor

nickaddy commented Mar 7, 2024

@KoWeiJAC Happy that this is now fully integrated :-) Have already approved, so good to go from my side once you have your other reviews.

@HalcyonJAC HalcyonJAC closed this Mar 7, 2024
@HalcyonJAC HalcyonJAC force-pushed the feat/2305-align-candidate-ethnicity-fields-on-apply branch from 6db9be3 to 0e1efbb Compare March 7, 2024 16:57
@KoWeiJAC KoWeiJAC merged commit b9505dc into main Mar 8, 2024
10 checks passed
@KoWeiJAC KoWeiJAC deleted the feat/2305-align-candidate-ethnicity-fields-on-apply branch March 8, 2024 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Align and display candidate ethnicity fields with the newly added categories on Apply
5 participants