Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/TS 247 Update Assessor Info #2355

Merged
merged 2 commits into from
Mar 19, 2024
Merged

Conversation

HalcyonJAC
Copy link
Contributor

@HalcyonJAC HalcyonJAC commented Mar 19, 2024

What's included?

Issue: User Raised Issue BR_000058 #247

  • Fix Firebase syntax in the store assessment.js.
  • Check the assessment question before accessing it.

Note: The PR required the changes in digital-platform: Bugfix/TS 247 Update Assessor Info #1054.

Who should test?

✅ Product owner
✅ Developers

How to test?

Example exercise: https://jac-admin-develop--pr2355-bugfix-ts-247-update-qejdbf0q.web.app/exercise/ONqUjAzhDS7rjh6dFJLB/tasks/all/independent-assessments
Example application: https://jac-admin-develop--pr2355-bugfix-ts-247-update-qejdbf0q.web.app/exercise/ONqUjAzhDS7rjh6dFJLB/applications/applied/application/X5ToXRooJbu9h6AVRtuA

  1. Go to the application and update the information (type, full name, email) of the first/second assessor.
  2. Go to "Independent Assessments" and check if the information of the assessor has been updated.

Risk - how likely is this to impact other areas?

🟢 No risk - this is a self-contained piece of work

Additional context

Include screen grabs, video demo, notes etc.

Related permissions

Have permissions been considered for this functionality?

  • No permission changes required
  • Permissions have been added / updated. Details:

PREVIEW:DEVELOP
can be OFF, DEVELOP or STAGING

Copy link

github-actions bot commented Mar 19, 2024

Visit the preview URL for this PR (updated for commit 97f3859):

https://jac-admin-develop--pr2355-bugfix-ts-247-update-qejdbf0q.web.app

(expires Thu, 18 Apr 2024 11:04:17 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 4e92cf51659207b0ae3509dc5c40edde50edfec0

@HalcyonJAC HalcyonJAC marked this pull request as ready for review March 19, 2024 11:05
@HalcyonJAC HalcyonJAC requested review from a team as code owners March 19, 2024 11:05
@Franceswog
Copy link
Contributor

On the application I was able to update the information (type, full name, email) of the first/second assessor.
and on Independent Assessments" the information of the assessor has been updated. No issues ..

@HalcyonJAC HalcyonJAC merged commit 08442e6 into main Mar 19, 2024
15 checks passed
@HalcyonJAC HalcyonJAC deleted the bugfix/ts-247-update-assessor-info branch March 19, 2024 11:43
@nickaddy
Copy link
Contributor

@HalcyonJAC Looks good to me - I could only see one Assessor in the list but the updates I made were reflected in their details :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants