Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/2361 Ensure SA upload can handle 6 questions #2362

Merged
merged 1 commit into from
Apr 3, 2024

Conversation

HalcyonJAC
Copy link
Contributor

@HalcyonJAC HalcyonJAC commented Apr 3, 2024

What's included?

Closes #2361

  • Add Career Highlights to the dropdown of Self Assessment with competencies.

Who should test?

✅ Product owner
✅ Developers

How to test?

Example exercise: https://jac-admin-develop--pr2362-bugfix-2361-sa-uploa-826z1cyu.web.app/exercise/kGW2SkyaMb7M68OAN5fR/details/assessments

  1. Go to "Assessment options" of an exercise.
  2. Update the assessment options.
  3. Tick "Self Assessment with competencies" and check if "Career Highlights" appears in the dropdown.

Risk - how likely is this to impact other areas?

🟢 No risk - this is a self-contained piece of work

Additional context

Screenshot:

Screenshot 2024-04-03 at 15 49 27

Related permissions

Have permissions been considered for this functionality?

  • No permission changes required
  • Permissions have been added / updated. Details:

PREVIEW:DEVELOP
can be OFF, DEVELOP or STAGING

Copy link

github-actions bot commented Apr 3, 2024

Visit the preview URL for this PR (updated for commit c14cbe7):

https://jac-admin-develop--pr2362-bugfix-2361-sa-uploa-826z1cyu.web.app

(expires Fri, 03 May 2024 14:52:38 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 4e92cf51659207b0ae3509dc5c40edde50edfec0

@HalcyonJAC HalcyonJAC force-pushed the bugfix/2361-sa-upload branch from b7c74b7 to c14cbe7 Compare April 3, 2024 13:19
@HalcyonJAC HalcyonJAC marked this pull request as ready for review April 3, 2024 14:50
@HalcyonJAC HalcyonJAC requested review from a team as code owners April 3, 2024 14:50
Copy link
Contributor

@nickaddy nickaddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@HalcyonJAC Looks good to me 👍

@HalcyonJAC HalcyonJAC merged commit b439271 into main Apr 3, 2024
11 of 14 checks passed
@HalcyonJAC HalcyonJAC deleted the bugfix/2361-sa-upload branch April 3, 2024 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ensure SA upload can handle 6 questions
3 participants