Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow users can edit external exercise if having update permission #2370

Merged
merged 1 commit into from
Apr 16, 2024

Conversation

KoWeiJAC
Copy link
Contributor

@KoWeiJAC KoWeiJAC commented Apr 11, 2024

What's included?

closes #2254

The problem here is that we don't want all users to be able to publish all exercises; we want Ops senior managers (but not Ops team members) to be able to publish all exercises, but we want 2/3 users to be able to publish only external exercises without having to gain approval.
we would only want Adela and Gemma (Operations Team Member) plus Ops Senior Leaders to publish external exercises.

Who should test?

✅ Product owner
✅ Developers
✅ UTG

Related permissions

Test as user in Operations Team Member group, without Can publish an exercise as live permission, but has following permissions:

  • Can read exercises
  • Can create exercises
  • Can update exercises

How to test?

Risk - how likely is this to impact other areas?

🟢 No risk - this is a self-contained piece of work

Additional context

Include screen grabs, video demo, notes etc.


PREVIEW:DEVELOP
can be OFF, DEVELOP or STAGING

Copy link

github-actions bot commented Apr 11, 2024

Visit the preview URL for this PR (updated for commit 6a52d13):

https://jac-admin-develop--pr2370-feat-2254-remove-ext-rkhkcll3.web.app

(expires Wed, 15 May 2024 13:43:35 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 4e92cf51659207b0ae3509dc5c40edde50edfec0

Copy link
Contributor

@nickaddy nickaddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@KoWeiJAC Happy to approve. Could you make sure the 'rules' are clearly laid out in the PR pls?

@HalcyonJAC HalcyonJAC force-pushed the feat/2254-remove-external-adverts-permisson-rules branch from 4905749 to 6a52d13 Compare April 15, 2024 13:39
@KoWeiJAC KoWeiJAC merged commit 2c3ce5a into main Apr 16, 2024
6 checks passed
@KoWeiJAC KoWeiJAC deleted the feat/2254-remove-external-adverts-permisson-rules branch April 16, 2024 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Streamlined publication of external adverts
5 participants