Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the required condition for the authorised field #2378

Merged
merged 1 commit into from
Apr 22, 2024

Conversation

drieJAC
Copy link
Contributor

@drieJAC drieJAC commented Apr 22, 2024

What's included?

A user requested that the authorisations should not be a required field, ie they should not have to specify s9(1) nor Class 1 Ticket.

Closes jac-uk/ticketing-system#288

Who should test?

✅ Product owner
✅ Developers
✅ UTG

How to test?

  1. Open a draft exercise
  2. Click on the 'Eligibility Information' link in the left sidebar
  3. Ensure neither of the Authorisations check boxes are checked
  4. Submit the form

Repeat above checking one and both of the checkboxes can be checked and the form submitted.

Risk - how likely is this to impact other areas?

🟢 No risk - this is a self-contained piece of work

Additional context

Screenshot 2024-04-22 at 14 14 16

Related permissions

Have permissions been considered for this functionality?

  • No permission changes required

PREVIEW:DEVELOP
can be OFF, DEVELOP or STAGING

Copy link

github-actions bot commented Apr 22, 2024

Visit the preview URL for this PR (updated for commit 029113a):

https://jac-admin-develop--pr2378-hotfix-make-authoris-zt0q6ahz.web.app

(expires Wed, 22 May 2024 13:23:09 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 4e92cf51659207b0ae3509dc5c40edde50edfec0

@drieJAC drieJAC merged commit 6363e7d into main Apr 22, 2024
9 checks passed
@drieJAC drieJAC deleted the hotfix/make-authorisations-not-required-field branch April 22, 2024 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants