Bugfix/TS 305 Shortlisting Other Statuses #2394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Visit the preview URL for this PR (updated for commit a7e39de): https://jac-admin-develop--pr2394-bugfix-ts-305-shortl-xpjwkr7r.web.app (expires Wed, 12 Jun 2024 12:33:15 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 4e92cf51659207b0ae3509dc5c40edde50edfec0 |
HalcyonJAC
requested review from
Franceswog,
tomlovesgithub,
drieJAC,
KoWeiJAC and
nickaddy
and removed request for
Franceswog and
KoWeiJAC
nickaddy
approved these changes
May 10, 2024
There was a problem hiding this comment.
Looks good, @HalcyonJAC. When this is released and the candidates are progressed to shortlisting stage, will Richard be able to dispatch the character consent request and create the panel packs?
KoWeiJAC
approved these changes
May 13, 2024
warrensearle
requested changes
May 13, 2024
There was a problem hiding this comment.
See comment here: https://github.com/jac-uk/ticketing-system/issues/305
I think it would be safer to introduce a new status for exercises with an 'Other' shortlisting method
drieJAC
approved these changes
May 13, 2024
warrensearle
approved these changes
May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's included?
Closes User Raised Issue BR_ADMIN_PR_000108 #305
Who should test?
✅ Product owner
✅ Developers
How to test?
Example exercise: https://jac-admin-develop--pr2394-bugfix-ts-305-shortl-xpjwkr7r.web.app/exercise/oNX74wd8yTHohVauj9UW/stages/review
Other PassedandOther Failedare available under New status.Risk - how likely is this to impact other areas?
🟢 No risk - this is a self-contained piece of work
Additional context
Demo:
video-27612893-1ccf64d2f84e4f947d50bf4456ae1a44.mp4
Related permissions
Have permissions been considered for this functionality?
PREVIEW:DEVELOP
can be OFF, DEVELOP or STAGING