-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/admin 2396 create scc eligibility download for legal exercises #2400
Feat/admin 2396 create scc eligibility download for legal exercises #2400
Conversation
Visit the preview URL for this PR (updated for commit a1f48ca): https://jac-admin-develop--pr2400-feat-admin-2396-crea-rjpjdx45.web.app (expires Fri, 28 Jun 2024 12:34:14 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 4e92cf51659207b0ae3509dc5c40edde50edfec0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All fields correspond with the appropriate fields.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@KoWeiJAC Looking good, but requires some changes; could you address the following pls:
- Candidate comments (in second and third annexes) should not appear in the download if there is no content in them
- The Recommendation column of the RLoS annex should include the selection in the recommendation dropdown as well as the content of the free text field, e.g. Reject (new line) Candidate will only be able to deliver 1 year of service.
- I've checked the age calculation and it doesn't look quite right - can you confirm which date is being referenced in the calculation in the case of this exercise?
3de1543
to
4264ed1
Compare
The SCC age currently is the length between the candidate date of birth and the expected service end date (Eligibility SCC date + reasonable length of service). For example, if the Eligibility SCC date is 20 June 2024, and the reasonable length of service is 5 years. Should we use Eligibility SCC date without adding reasonable length of service as reference? |
@KoWeiJAC Hopefully there are my final comments on the download:
|
@nickaddy
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@KoWeiJAC Thanks for your patience on this ticket - it's looking great. We can now move forward to testing it on some live exercises :-)
@HalcyonJAC I cannot do a final review on Ko Wei's work because the download appears to be broken - pls repair and let me know when I can retest. |
What's included?
closes #2396
Who should test?
✅ Product owner
✅ Developers
✅ UTG
How to test?
Download SCC Annex report
to download the reportExample exercises:
🟢 No risk - this is a self-contained piece of work
Additional context
Include screen grabs, video demo, notes etc.
Related permissions
Have permissions been considered for this functionality?
PREVIEW:DEVELOP
can be OFF, DEVELOP or STAGING