Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/admin 2396 create scc eligibility download for legal exercises #2400

Conversation

KoWeiJAC
Copy link
Contributor

@KoWeiJAC KoWeiJAC commented May 15, 2024

What's included?

closes #2396

Who should test?

✅ Product owner
✅ Developers
✅ UTG

How to test?

  • Go to the preview link: https://jac-admin-develop--pr2400-feat-admin-2396-crea-rjpjdx45.web.app/exercise/S9V9R15MGRjCDHdcRQRZ/reports/eligibility-issues
  • Click Download SCC Annex report to download the report
  • Check contents of following sections are correct
    • Candidates who do not meet the Statutory Eligibility Criteria
    • Candidates recommended to proceed and the reasons why they are considered to meet the ASC - Previous Judicial Experience
    • Candidates recommended to discuss and the reasons why they are considered to potentially meet the ASC - Previous Judicial Experience, necessary skills in some other significant way
    • Candidates recommended to reject and the reasons why they are considered to not meet the ASC - Previous Judicial Experience through a quasi-judicial role or showing the skills in some other significant way

Candidates who will not be able to provide 3 years reasonable service when recommendations are made to the Lord Chancellor

Example exercises:

🟢 No risk - this is a self-contained piece of work

Additional context

Include screen grabs, video demo, notes etc.

Related permissions

Have permissions been considered for this functionality?

  • No permission changes required
  • Permissions have been added / updated. Details:

PREVIEW:DEVELOP
can be OFF, DEVELOP or STAGING

Copy link

github-actions bot commented May 15, 2024

Visit the preview URL for this PR (updated for commit a1f48ca):

https://jac-admin-develop--pr2400-feat-admin-2396-crea-rjpjdx45.web.app

(expires Fri, 28 Jun 2024 12:34:14 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 4e92cf51659207b0ae3509dc5c40edde50edfec0

@KoWeiJAC KoWeiJAC marked this pull request as ready for review May 15, 2024 14:18
@KoWeiJAC KoWeiJAC requested review from a team as code owners May 15, 2024 14:18
Copy link
Contributor

@NormaJAC NormaJAC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All fields correspond with the appropriate fields.

Copy link
Contributor

@nickaddy nickaddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@KoWeiJAC Looking good, but requires some changes; could you address the following pls:

  • Candidate comments (in second and third annexes) should not appear in the download if there is no content in them
  • The Recommendation column of the RLoS annex should include the selection in the recommendation dropdown as well as the content of the free text field, e.g. Reject (new line) Candidate will only be able to deliver 1 year of service.
  • I've checked the age calculation and it doesn't look quite right - can you confirm which date is being referenced in the calculation in the case of this exercise?

@HalcyonJAC HalcyonJAC force-pushed the feat/admin-2396-create-scc-eligibility-download-for-legal-exercises branch from 3de1543 to 4264ed1 Compare May 21, 2024 10:04
@KoWeiJAC
Copy link
Contributor Author

KoWeiJAC commented May 21, 2024

  • I've checked the age calculation and it doesn't look quite right - can you confirm which date is being referenced in the calculation in the case of this exercise?

@nickaddy

The SCC age currently is the length between the candidate date of birth and the expected service end date (Eligibility SCC date + reasonable length of service).

For example, if the Eligibility SCC date is 20 June 2024, and the reasonable length of service is 5 years.
The expected service end date will be June 2029.
If the candidate date of birth is JAN 1980, the SCC age will be 49 years and 7 months old.

Should we use Eligibility SCC date without adding reasonable length of service as reference?

@nickaddy
Copy link
Contributor

@KoWeiJAC Hopefully there are my final comments on the download:

  • Amend name of download to, e.g. JAC00787_SCC Eligibility Annexes
  • Age calculation in 3rd column of final annex (see below) should just be the candidate’s age on the Character and Selection SCC date (specified in the exercise set-up)
  • Remove text in red
image

@KoWeiJAC
Copy link
Contributor Author

@nickaddy
These places have been updated, could you help me to review them again? Thanks

  • Candidate comments (in second and third annexes) should not appear in the download if there is no content in them
  • The Recommendation column of the RLoS annex should include the selection in the recommendation dropdown as well as the content of the free text field, e.g. Reject (new line) Candidate will only be able to deliver 1 year of service.
  • Amend name of download to, e.g. JAC00787_SCC Eligibility Annexes
  • Age calculation in 3rd column of final annex (see below) should just be the candidate’s age on the Character and Selection - SCC date (specified in the exercise set-up)
    Remove text in red

@KoWeiJAC KoWeiJAC requested a review from nickaddy May 23, 2024 11:24
Copy link
Contributor

@nickaddy nickaddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@KoWeiJAC Thanks for your patience on this ticket - it's looking great. We can now move forward to testing it on some live exercises :-)

@nickaddy
Copy link
Contributor

@HalcyonJAC I cannot do a final review on Ko Wei's work because the download appears to be broken - pls repair and let me know when I can retest.

@HalcyonJAC HalcyonJAC merged commit 65a0f85 into main May 31, 2024
9 checks passed
@HalcyonJAC HalcyonJAC deleted the feat/admin-2396-create-scc-eligibility-download-for-legal-exercises branch May 31, 2024 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create SCC Eligibility download covering 3 annexes for legal exercises
7 participants