Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make last release of each repo visible #2405

Merged
merged 4 commits into from
May 31, 2024

Conversation

drieJAC
Copy link
Contributor

@drieJAC drieJAC commented May 22, 2024

What's included?

Added new page and route for displaying the latest releases.
Added dedicated permission to view releases.
Optionally showing link to releases page if permission applies.

This PR relies on the following PR being deployed on the Digital Platform: jac-uk/digital-platform#1093

Closes #2398

Who should test?

✅ Product owner
✅ Developers
✅ UTG

How to test?

Go to: https://jac-admin-develop--pr2405-feature-2398-display-bdzye2m7.web.app/

Test 1

  • Login as a Digital Super User
  • Go to the Exercises page
  • Click on the releases link at the top of the page (see Figure 1 below)
  • The Latest Releases page should open (see Figure 2 below)

Test 1

  • Login as a user who is NOT a Digital Super User
  • Go to the Exercises page
  • If you click on the releases link at the top of the page nothing should happen (see Figure 1 below)

Risk - how likely is this to impact other areas?

🟢 No risk - this is a self-contained piece of work

Additional context

Figure 1

Screenshot 2024-05-22 at 12 35 42

Figure 2

Screenshot 2024-05-22 at 12 31 39

Related permissions

Have permissions been considered for this functionality?

  • No permission changes required

PREVIEW:DEVELOP
can be OFF, DEVELOP or STAGING

Added dedicated permission to view releases.
Optionally showing link to releases page if permission applies.
Copy link

github-actions bot commented May 22, 2024

Visit the preview URL for this PR (updated for commit febbe51):

https://jac-admin-develop--pr2405-feature-2398-display-bdzye2m7.web.app

(expires Sat, 22 Jun 2024 10:42:57 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 4e92cf51659207b0ae3509dc5c40edde50edfec0

@KoWeiJAC
Copy link
Contributor

@drieJAC
I just tested with the preview link: https://jac-admin-develop--pr2405-feature-2398-display-bdzye2m7.web.app/exercises.
I logged in as Digital Super User and click the release link. I can't see the release page.
Not sure if there's unexpected issue ?

Screenshot 2024-05-22 at 13 07 20

Copy link
Contributor

@HalcyonJAC HalcyonJAC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be good to add an initial loading indicator as the cloud function takes time to get data.

@drieJAC drieJAC merged commit 972fc38 into main May 31, 2024
6 checks passed
@drieJAC drieJAC deleted the feature/2398-display-latest-releases branch May 31, 2024 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make last release of each repo visible
5 participants