Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/2419 Reference statuses in Independent Assessments task #2420

Conversation

HalcyonJAC
Copy link
Contributor

@HalcyonJAC HalcyonJAC commented Jun 13, 2024

What's included?

Closes #2419

Related PRs:

Who should test?

✅ Product owner
✅ Developers
✅ UTG

How to test?

Example exercises:

Steps:

  1. Go to the Independent Assessments task.
  2. Check if the options and counts in the dropdown are generated based on the application statuses.

Risk - how likely is this to impact other areas?

🟢 No risk - this is a self-contained piece of work

Additional context

Demo:

Screen.Recording.2024-06-17.at.11.00.40.mov

Related permissions

Have permissions been considered for this functionality?

  • No permission changes required
  • Permissions have been added / updated. Details:

PREVIEW:DEVELOP
can be OFF, DEVELOP or STAGING

Copy link

github-actions bot commented Jun 13, 2024

Visit the preview URL for this PR (updated for commit 1bff0e7):

https://jac-admin-develop--pr2420-feature-2419-referen-7tqgsgb3.web.app

(expires Thu, 18 Jul 2024 10:45:22 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 4e92cf51659207b0ae3509dc5c40edde50edfec0

@HalcyonJAC HalcyonJAC marked this pull request as ready for review June 17, 2024 10:11
@HalcyonJAC HalcyonJAC requested review from a team as code owners June 17, 2024 10:11
@HalcyonJAC HalcyonJAC requested review from Franceswog, tomlovesgithub, drieJAC, KoWeiJAC, NormaJAC and nickaddy and removed request for KoWeiJAC June 17, 2024 10:11
@nickaddy
Copy link
Contributor

@HalcyonJAC I believe this works, however, I just had a thought: this may never happen, but if there was a case where there was a small exercise and IAs was the first task, i.e. no QT, no sift before, would the application status appear as blank in the dropdown? And, if so, would users be able to select and progress all candidates with a blank status?

@HalcyonJAC
Copy link
Contributor Author

@nickaddy That case might happen indeed. For now, the blank status will not appear in the dropdown. I could make changes to support selecting candidates with a blank status if you would like.

@nickaddy
Copy link
Contributor

@HalcyonJAC Better safe than sorry! Pls proceed with including the 'blank' option in the dropdown.

@HalcyonJAC
Copy link
Contributor Author

@nickaddy The Blank option is included in the dropdown. Could you test it, please?

Copy link
Contributor

@nickaddy nickaddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@HalcyonJAC That works great, thx for the extra work on this :-)

I tested on this exercise - could you roll back to the beginning of the task for UT pls?

Copy link
Contributor

@NormaJAC NormaJAC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works

@HalcyonJAC HalcyonJAC merged commit 500614e into main Jun 20, 2024
18 checks passed
@HalcyonJAC HalcyonJAC deleted the feature/2419-reference-statuses-in-independent-assessments-task branch June 20, 2024 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reference statuses in Independent Assessments task
6 participants