Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2413/ra task page improve #2421

Merged
merged 3 commits into from
Jun 21, 2024
Merged

2413/ra task page improve #2421

merged 3 commits into from
Jun 21, 2024

Conversation

tomlovesgithub
Copy link
Contributor

What's included?

  • Address display issues (overlapping of application id and email, by removing application id and instead linking to application from name field)
  • Include blank options for RA applies to and RA allocated dropdowns so that Admins can 'deselect' any options they have chosen
  • The total applications number is was not correct - it was displaying equal the number of candidates requiring RAs instead, field now labelled correctly
  • Remove the Stages filter
  • Add 'Mark all candidates as unactioned' button

Who should test?

✅ Product owner
✅ Developers
✅ UTG

How to test?

Visit an RA report page, and ensure the listed changes are present and the unaction candidates button works as expected.

Risk - how likely is this to impact other areas?

🟢 Low risk


PREVIEW:DEVELOP
can be OFF, DEVELOP or STAGING

Copy link

github-actions bot commented Jun 13, 2024

Visit the preview URL for this PR (updated for commit 1c8005e):

https://jac-admin-develop--pr2421-2413-ra-task-page-im-ffdbxafz.web.app

(expires Wed, 17 Jul 2024 16:39:43 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 4e92cf51659207b0ae3509dc5c40edde50edfec0

Copy link
Contributor

@nickaddy nickaddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @tomlovesgithub!

Copy link
Contributor

@HalcyonJAC HalcyonJAC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@tomlovesgithub tomlovesgithub merged commit 825ee93 into main Jun 21, 2024
6 checks passed
@tomlovesgithub tomlovesgithub deleted the 2413/ra-task-page-improve branch June 21, 2024 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants