Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/2392 Limit Z-score banding calculation to 2 decimal places #2430

Conversation

HalcyonJAC
Copy link
Contributor

@HalcyonJAC HalcyonJAC commented Jun 21, 2024

What's included?

Closes #2392

Who should test?

✅ Product owner
✅ Developers
✅ UTG

How to test?

Example exercise: https://jac-admin-develop--pr2430-feature-2392-limit-z-9rdeeby0.web.app/exercise/NmzLHCZMAsKjH3GwrCxb/tasks/all/qualifyingTest/finalised/

  1. Go to "QT Merit List".
  2. Check if a single band for each z-score rounded up to 2 decimal places displays in the table.

Risk - how likely is this to impact other areas?

🟢 No risk - this is a self-contained piece of work

Additional context

Include screen grabs, video demo, notes etc.

Related permissions

Have permissions been considered for this functionality?

  • No permission changes required
  • Permissions have been added / updated. Details:

PREVIEW:DEVELOP
can be OFF, DEVELOP or STAGING

Copy link

github-actions bot commented Jun 21, 2024

Visit the preview URL for this PR (updated for commit 8cda34a):

https://jac-admin-develop--pr2430-feature-2392-limit-z-9rdeeby0.web.app

(expires Thu, 25 Jul 2024 11:22:25 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 4e92cf51659207b0ae3509dc5c40edde50edfec0

@HalcyonJAC HalcyonJAC marked this pull request as ready for review June 25, 2024 11:23
@HalcyonJAC HalcyonJAC requested review from a team as code owners June 25, 2024 11:23
@HalcyonJAC HalcyonJAC requested review from NormaJAC, tomlovesgithub, drieJAC, KoWeiJAC, nickaddy and Franceswog and removed request for KoWeiJAC June 25, 2024 11:23
@nickaddy
Copy link
Contributor

@HalcyonJAC Quick question, would this be retroactive on QT tasks that have already been completed or will it only work on new exercises going forward?

@HalcyonJAC
Copy link
Contributor Author

@HalcyonJAC Quick question, would this be retroactive on QT tasks that have already been completed or will it only work on new exercises going forward?

@nickaddy It will only work in the incompleted QT tasks as the pass mark has been set up. Does that make sense?

@HalcyonJAC HalcyonJAC merged commit 854dd5d into main Jun 27, 2024
6 checks passed
@HalcyonJAC HalcyonJAC deleted the feature/2392-limit-z-score-banding-calculation-to-2-decimal-places branch June 27, 2024 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Limit Z-score banding calculation to 2 decimal places
5 participants