Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/apply 1192 Membership selection #2473

Merged
merged 1 commit into from
Jul 1, 2024

Conversation

KoWeiJAC
Copy link
Contributor

@KoWeiJAC KoWeiJAC commented Jun 28, 2024

What's included?

Fix https://app.zenhub.com/workspaces/platform-development-5ea838cd2aec471eb6d14139/issues/gh/jac-uk/apply/1192

  • Fix exercise.otherMembership.value always be "object-inputevent"

Who should test?

✅ Product owner
✅ Developers
✅ UTG

How to test?

Screen.Recording.2024-06-28.at.14.43.01.mov

Risk - how likely is this to impact other areas?

🟢 No risk - this is a self-contained piece of work

Additional context

Include screen grabs, video demo, notes etc.

Related permissions

Have permissions been considered for this functionality?

  • No permission changes required
  • Permissions have been added / updated. Details:

PREVIEW:DEVELOP
can be OFF, DEVELOP or STAGING

Copy link

github-actions bot commented Jun 28, 2024

Visit the preview URL for this PR (updated for commit 30f5635):

https://jac-admin-develop--pr2473-bugfix-apply-1192-fi-xhfrt8w2.web.app

(expires Wed, 31 Jul 2024 10:05:23 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 4e92cf51659207b0ae3509dc5c40edde50edfec0

@KoWeiJAC KoWeiJAC marked this pull request as ready for review June 28, 2024 13:51
@KoWeiJAC KoWeiJAC requested review from a team as code owners June 28, 2024 13:51
@HalcyonJAC HalcyonJAC changed the title fix exercise.otherMembership.value always be "object-inputevent" Bugfix/apply 1192 Membership selection Jul 1, 2024
@HalcyonJAC HalcyonJAC merged commit 0b708a7 into main Jul 1, 2024
15 checks passed
@HalcyonJAC HalcyonJAC deleted the bugfix/apply-1192-fix-membership-selection branch July 1, 2024 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants