Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/Process single batch notifications #2474

Merged
merged 1 commit into from
Jul 1, 2024

Conversation

HalcyonJAC
Copy link
Contributor

@HalcyonJAC HalcyonJAC commented Jul 1, 2024

What's included?

Issue:
Screenshot 2024-07-01 at 10 35 18

Fix:

  • Rename cloud function from processNotifications to processNotificationsNow.

Who should test?

✅ Product owner
✅ Developer

How to test?

  1. Go to "Notifications" section and hit "Process now (single batch)" button.
  2. Check if the button works correctly.

Risk - how likely is this to impact other areas?

🟢 No risk - this is a self-contained piece of work

Additional context

Demo:

video-29128637-9ee727fa4bfe565eef1b110ba255ab3c.mp4

Related permissions

Have permissions been considered for this functionality?

  • No permission changes required
  • Permissions have been added / updated. Details:

PREVIEW:DEVELOP
can be OFF, DEVELOP or STAGING

Copy link

github-actions bot commented Jul 1, 2024

Visit the preview URL for this PR (updated for commit 97f71ec):

https://jac-admin-develop--pr2474-bugfix-process-singl-1mmq639d.web.app

(expires Wed, 31 Jul 2024 09:39:03 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 4e92cf51659207b0ae3509dc5c40edde50edfec0

@HalcyonJAC HalcyonJAC marked this pull request as ready for review July 1, 2024 09:36
@HalcyonJAC HalcyonJAC requested review from a team as code owners July 1, 2024 09:36
@HalcyonJAC HalcyonJAC requested review from NormaJAC, tomlovesgithub, drieJAC, KoWeiJAC and nickaddy and removed request for KoWeiJAC July 1, 2024 09:36
@HalcyonJAC HalcyonJAC merged commit 806784f into main Jul 1, 2024
18 checks passed
@HalcyonJAC HalcyonJAC deleted the bugfix/process-single-batch-notifications branch July 1, 2024 09:53
@nickaddy
Copy link
Contributor

nickaddy commented Jul 1, 2024

@HalcyonJAC After clicking Process now and the function having run, I would expect the list on screen to clear and items move to the Sent tab, but the items remain on screen. Is this correct?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants