Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/TS 343 Unable to amend application data #2476

Merged
merged 1 commit into from
Jul 2, 2024

Conversation

HalcyonJAC
Copy link
Contributor

@HalcyonJAC HalcyonJAC commented Jul 2, 2024

What's included?

Closes User Raised Issue BR_ADMIN_PR_000141 #343

  • Fix the save functionality in the EditableField component.

Who should test?

✅ Product owner
✅ Developers

How to test?

Example application: https://jac-admin-develop--pr2476-bugfix-ts-343-unable-n0mpgeth.web.app/exercise/g45SG9vPFlhInL6yDonh/applications/draft/application/0h8NUJ5GPEiIBfL35Shh

Steps:

  1. Go to an application and amend the data.
  2. Check if the data can be saved correctly.

Risk - how likely is this to impact other areas?

🟢 No risk - this is a self-contained piece of work

Additional context

Demo:

video-29166888-b6548bcc3394d74cd3da11fa6fc5033f.mp4

Related permissions

Have permissions been considered for this functionality?

  • No permission changes required
  • Permissions have been added / updated. Details:

PREVIEW:DEVELOP
can be OFF, DEVELOP or STAGING

Copy link

github-actions bot commented Jul 2, 2024

Visit the preview URL for this PR (updated for commit a564aa7):

https://jac-admin-develop--pr2476-bugfix-ts-343-unable-n0mpgeth.web.app

(expires Thu, 01 Aug 2024 10:29:28 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 4e92cf51659207b0ae3509dc5c40edde50edfec0

@HalcyonJAC HalcyonJAC marked this pull request as ready for review July 2, 2024 10:15
@HalcyonJAC HalcyonJAC requested review from a team as code owners July 2, 2024 10:15
Copy link
Member

@warrensearle warrensearle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code change looks good to me 👍

Copy link
Contributor

@nickaddy nickaddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@HalcyonJAC HalcyonJAC merged commit f7eb5be into main Jul 2, 2024
17 of 18 checks passed
@HalcyonJAC HalcyonJAC deleted the bugfix/ts-343-unable-amend-application branch July 2, 2024 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants