Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/2505 Apply user role filters on Exercise contacts page #2510

Merged

Conversation

HalcyonJAC
Copy link
Contributor

@HalcyonJAC HalcyonJAC commented Jul 30, 2024

What's included?

Closes #2505

Who should test?

✅ Product owner
✅ Developers
✅ UTG

How to test?

Example exercise

Steps:

  1. Go to the exercise contacts page.
  2. Amend the "Senior selection exercise manager" fields and check if only users with the "Operations Senior Manager" role appear in the dropdown.
  3. Amend the following fields and check if only users with the "Operations Team Member" role appear in the dropdown.
    • Selection exercise manager
    • Selection exercise officers

Risk - how likely is this to impact other areas?

🟢 No risk - this is a self-contained piece of work

Additional context

Include screen grabs, video demo, notes etc.

Related permissions

Have permissions been considered for this functionality?

  • No permission changes required
  • Permissions have been added / updated. Details:

PREVIEW:DEVELOP
can be OFF, DEVELOP or STAGING

Copy link

github-actions bot commented Jul 30, 2024

Visit the preview URL for this PR (updated for commit 0380853):

https://jac-admin-develop--pr2510-feature-2505-apply-u-cilfp82k.web.app

(expires Fri, 30 Aug 2024 09:03:07 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 4e92cf51659207b0ae3509dc5c40edde50edfec0

@HalcyonJAC HalcyonJAC marked this pull request as ready for review July 30, 2024 14:38
@HalcyonJAC HalcyonJAC requested review from a team as code owners July 30, 2024 14:38
@HalcyonJAC HalcyonJAC requested review from NormaJAC, tomlovesgithub, drieJAC, KoWeiJAC, nickaddy and Franceswog and removed request for KoWeiJAC July 30, 2024 14:38
@KoWeiJAC KoWeiJAC self-requested a review July 30, 2024 15:22
@nickaddy
Copy link
Contributor

@HalcyonJAC Could you create a preview URL on Admin Production pls? We don't have all the user groups set up on Develop, hence it's not possible to fully test this ticket.

Copy link

github-actions bot commented Jul 31, 2024

Visit the preview URL for this PR (updated for commit 0380853):

https://jac-apply-admin-production--pr2510-feature-2505-apply-1ut29iwh.web.app

(expires Fri, 30 Aug 2024 08:59:34 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 2f31b7832d58b04f07d3816f45a5d09d461ded5e

@HalcyonJAC
Copy link
Contributor Author

@HalcyonJAC Could you create a preview URL on Admin Production pls? We don't have all the user groups set up on Develop, hence it's not possible to fully test this ticket.

@nickaddy here is the preview link on production.

@nickaddy
Copy link
Contributor

@HalcyonJAC The Senior dropdown is not working for me - this should be filtered by Ops Senior Manager role. Could you fix pls?

@HalcyonJAC
Copy link
Contributor Author

@nickaddy It has been sorted. Could you test it again, please?

Copy link
Contributor

@nickaddy nickaddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@HalcyonJAC HalcyonJAC merged commit cf8f763 into main Jul 31, 2024
12 checks passed
@HalcyonJAC HalcyonJAC deleted the feature/2505-apply-user-role-filters-on-exercise-contacts-page branch July 31, 2024 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Apply user role filters on Exercise contacts page
5 participants