-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
change exercise reference prefix for external and Welsh GOV #2514
change exercise reference prefix for external and Welsh GOV #2514
Conversation
Visit the preview URL for this PR (updated for commit a307ee5): https://jac-admin-develop--pr2514-feat-admin-2483-mech-j8ve5bae.web.app (expires Thu, 29 Aug 2024 14:54:39 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 4e92cf51659207b0ae3509dc5c40edde50edfec0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Both exercises have the expected prefixes.
@MattHowley I'm happy with this solution, but just to point out that you cannot retrospectively change the prefix, i.e. if you change your answer to |
Totally agree @nickaddy - not an issue if it's locked in from the off and, if a mistake occurs, recreate as you say. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@KoWeiJAC I've observed that if you retrospectively change the exercise type, e.g. from JAC to external, the prefix doesn't change. I've discussed with Matt and we agree that's OK, we are content with this solution.
What's included?
Closes #2483
Who should test?
✅ Product owner
✅ Developers
✅ UTG
How to test?
JAC
prefixGOW
prefixRisk - how likely is this to impact other areas?
🟢 No risk - this is a self-contained piece of work
Additional context
Include screen grabs, video demo, notes etc.
Related permissions
Have permissions been considered for this functionality?
PREVIEW:DEVELOP
can be OFF, DEVELOP or STAGING