Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change exercise reference prefix for external and Welsh GOV #2514

Merged
merged 1 commit into from
Jul 31, 2024

Conversation

KoWeiJAC
Copy link
Contributor

What's included?

Closes #2483

Who should test?

✅ Product owner
✅ Developers
✅ UTG

How to test?

  • Go to the preview link:
  • The exercise table should sort by the number part of reference number
  • Create a JAC exercise, the reference number should had JAC prefix
  • Create a Welsh government exercise, the reference number should had GOW prefix
Screenshot 2024-07-30 at 15 49 48 - Create a external exercise, the reference number should had `EXT` prefix

Risk - how likely is this to impact other areas?

🟢 No risk - this is a self-contained piece of work

Additional context

Include screen grabs, video demo, notes etc.

Related permissions

Have permissions been considered for this functionality?

  • No permission changes required
  • Permissions have been added / updated. Details:

PREVIEW:DEVELOP
can be OFF, DEVELOP or STAGING

Copy link

Visit the preview URL for this PR (updated for commit a307ee5):

https://jac-admin-develop--pr2514-feat-admin-2483-mech-j8ve5bae.web.app

(expires Thu, 29 Aug 2024 14:54:39 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 4e92cf51659207b0ae3509dc5c40edde50edfec0

Copy link
Contributor

@NormaJAC NormaJAC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both exercises have the expected prefixes.

@nickaddy
Copy link
Contributor

@MattHowley I'm happy with this solution, but just to point out that you cannot retrospectively change the prefix, i.e. if you change your answer to Is this a Welsh Government exercise? later, the prefix won't change. If you made a mistake, you'd just delete the exercise and create a new one. Is that OK? I'm not convinced it's worth spending additional time on that, now that we have a working solution.

@MattHowley
Copy link

@MattHowley I'm happy with this solution, but just to point out that you cannot retrospectively change the prefix, i.e. if you change your answer to Is this a Welsh Government exercise? later, the prefix won't change. If you made a mistake, you'd just delete the exercise and create a new one. Is that OK? I'm not convinced it's worth spending additional time on that, now that we have a working solution.

Totally agree @nickaddy - not an issue if it's locked in from the off and, if a mistake occurs, recreate as you say.

Copy link
Contributor

@nickaddy nickaddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@KoWeiJAC I've observed that if you retrospectively change the exercise type, e.g. from JAC to external, the prefix doesn't change. I've discussed with Matt and we agree that's OK, we are content with this solution.

@KoWeiJAC KoWeiJAC merged commit d289ff9 into main Jul 31, 2024
6 checks passed
@KoWeiJAC KoWeiJAC deleted the feat/admin-2483-mechanism-to-distinguish-exercise branch July 31, 2024 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Introduce a mechanism to distinguish exercises to be excluded from statistics
6 participants