Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/2566 Functionality of Copying Exercise #2569

Merged
merged 1 commit into from
Sep 23, 2024

Conversation

HalcyonJAC
Copy link
Contributor

@HalcyonJAC HalcyonJAC commented Sep 20, 2024

What's included?

Closes #2566

  • Filter ignored fields when copying an exercise.

Who should test?

✅ Product owner
✅ Developers

How to test?

  1. Find an exercise and copy the exercise to clipboard.
  2. Submit the exercise for approval and publish it once approved.
  3. Check if you can create test applications.

Risk - how likely is this to impact other areas?

🟢 No risk - this is a self-contained piece of work

Additional context

Demo:

Screen.Recording.2024-09-20.at.09.38.36.mov

Related permissions

Have permissions been considered for this functionality?

  • No permission changes required
  • Permissions have been added / updated. Details:

PREVIEW:DEVELOP
can be OFF, DEVELOP or STAGING

Copy link

github-actions bot commented Sep 20, 2024

Visit the preview URL for this PR (updated for commit 0edab2c):

https://jac-admin-develop--pr2569-bugfix-2566-copy-exe-cs69icjm.web.app

(expires Sun, 20 Oct 2024 08:48:29 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 4e92cf51659207b0ae3509dc5c40edde50edfec0

@nickaddy
Copy link
Contributor

@HalcyonJAC This all works as it should, however, I was alarmed to see that the Review stage has reappeared in the exercise I copied.

@HalcyonJAC
Copy link
Contributor Author

@warrensearle What the default _processingVersion should we use when creating an exercise?

Copy link
Member

@warrensearle warrensearle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@warrensearle warrensearle merged commit b52053e into main Sep 23, 2024
15 checks passed
@warrensearle warrensearle deleted the bugfix/2566-copy-exercise branch September 23, 2024 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bugfix: Functionality of Copying Exercise
5 participants