Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/2560 update phone number fields #2594

Merged
merged 4 commits into from
Nov 1, 2024

Conversation

drieJAC
Copy link
Contributor

@drieJAC drieJAC commented Oct 30, 2024

What's included?

The phone number field is now readonly in both the Application and Candidate form in Admin.
The mobile field has been added which validates for a UK mobile number only, ie landline or international formatted numbers are invalid.
Sets the mobileVerifiedAt field to null so when the mobile number is changed the candidate will be forced to verify the number (though this is part of a separate ticket).

Closes #2560

Who should test?

✅ Product owner
✅ Developers
✅ UTG

How to test?

For the tests below you will be modifying data in an application and the candidate's profile page.

Test 1
Go to the following URL: https://jac-admin-develop--pr2594-feature-2560-update-rgjg76oh.web.app/

  • Find an application in an exercise and make a note of the link to the application
  • Click the Edit button
  • See that the phone field cannot be edited
  • Click to change the mobile field
  • Try to enter some invalid numbers and see an error message display (+447971596199, 01272203729, etc)
  • Enter a valid UK mobile number, eg 07971596199 and press 'Save' - MAKE A NOTE OF THIS NUMBER
  • The number will update with no error

Test 2

  • Go to the candidate page for the user in the application you used above
  • Ensure the mobile number here matches the one you entered in the previous section!
  • Click the Edit button
  • See that the phone field cannot be edited
  • Click to change the mobile field
  • Try to enter some invalid numbers and see an error message display (+447971596199, 01272203729, etc)
  • Enter a valid UK mobile number, eg 07971596199 and press 'Save' - MAKE A NOTE OF THIS NUMBER
  • The number will update with no error

Test 3

  • Go back to the application you used above
  • Check that the mobile number is different from the one you entered in the candidate profile

Resources/Screenshots/Videos

Screen.Recording.2024-10-30.at.11.24.31.mov

Risk - how likely is this to impact other areas?

🟢 No risk - this is a self-contained piece of work

Related permissions

Have permissions been considered for this functionality?

  • No permission changes required

PREVIEW:DEVELOP
can be OFF, DEVELOP or STAGING

Added validation calls for them.
Removed ability to edit phone numbers so read only.
Copy link

github-actions bot commented Oct 30, 2024

Visit the preview URL for this PR (updated for commit 50c41d8):

https://jac-admin-develop--pr2594-feature-2560-update-rgjg76oh.web.app

(expires Sun, 01 Dec 2024 10:49:16 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 4e92cf51659207b0ae3509dc5c40edde50edfec0

@drieJAC drieJAC added Passed UT and removed Needs UT labels Nov 1, 2024
@drieJAC drieJAC merged commit e7d3be6 into main Nov 1, 2024
9 checks passed
@drieJAC drieJAC deleted the feature/2560-update-phone-number-fields branch November 1, 2024 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Updates to phone number fields on Admin
3 participants