Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/2515 full application submitted #2602

Merged
merged 4 commits into from
Nov 18, 2024

Conversation

KoWeiJAC
Copy link
Contributor

@KoWeiJAC KoWeiJAC commented Nov 11, 2024

What's included?

closes #2515

Who should test?

✅ Product owner
✅ Developers
✅ UTG

How to test?

Staged exercises with open application after 18/06/2024 can see the new full application submitted status

Staged exercises with open application before 18/06/2024 will not apply the new full application submitted status

Risk - how likely is this to impact other areas?

🟠 Medium risk - this does change code that is shared with other areas

Additional context

Include screen grabs, video demo, notes etc.

Related permissions

Have permissions been considered for this functionality?

  • No permission changes required
  • Permissions have been added / updated. Details:

PREVIEW:DEVELOP
can be OFF, DEVELOP or STAGING

Copy link

github-actions bot commented Nov 12, 2024

Visit the preview URL for this PR (updated for commit eb42278):

https://jac-admin-develop--pr2602-feat-2515-full-appli-k7d3ccp6.web.app

(expires Wed, 18 Dec 2024 12:22:45 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 4e92cf51659207b0ae3509dc5c40edde50edfec0

@nickaddy
Copy link
Contributor

@KoWeiJAC A few issues here:

  1. I can't test because I'm being asked to verify the email
    image

  2. The count on the Stage tab is not updating when the candidate is moved back to Shortlisting

  3. I think there is a misunderstanding with logic here: the application status becomes 'Full application submitted' when the candidate completes all second stage sections and the review then clicks submit (this is also when the Notify email should be dispatched to candidates). According to the PR, the logic seems to be that the SETs allocate the full application submitted status to the application.

@KoWeiJAC
Copy link
Contributor Author

KoWeiJAC commented Nov 12, 2024

Hi @nickaddy,

  1. The preview link has been updated for skipping email verification of dummy accounts: https://jac-apply-develop--pr1258-feat-2515-full-appli-x7vkvrfi.web.app/vacancy/tzGyKNa4SakZ0CS8241V/

  2. The count would update in background, but it may take several minutes for updating. So, if you check it after a while, the count would update.

Screen.Recording.2024-11-12.at.16.31.53.mov
  1. If candidate submit second stage application, the status will update to 'Full application submitted'. This has been implemented on Apply site and DP.
Screen.Recording.2024-11-12.at.16.35.04.mov

@HalcyonJAC HalcyonJAC merged commit 6ddbab7 into main Nov 18, 2024
6 checks passed
@HalcyonJAC HalcyonJAC deleted the feat/2515-full-application-submitted branch November 18, 2024 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Facilitate completion of full application in staged exercises
7 participants