Correct Incorrect Text Appearing Due To Lookups #2603
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s they are to do with lookups being incorrect.
|
Visit the preview URL for this PR (updated for commit e485666): https://jac-admin-develop--pr2603-bugfix-2600-correct-iyu0ze8m.web.app (expires Thu, 12 Dec 2024 16:39:25 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 4e92cf51659207b0ae3509dc5c40edde50edfec0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's included?
Two issues were reported, one had a ticket raised for it but they are connected so both go fixed in this ticket.
The issues arise because of overlapping references being used in the lookup helper.
Issue 1) 'Professional assessor' was being displayed next to occupation. This got flagged by a candidate and reported in the support channel. The fix involved removing the word assessor and hardcoding that in the template. This is a bit of a hack so will be nice to modify the way we do this lookup in the future to prevent this issue from arising again as it surely will.
Issue 2) The exercise type field was displaying 'Strategic Leadership Questions' instead of 'Leadership'.
Closes #2600
Closes #2601
Who should test?
✅ Product owner
✅ Developers
✅ UTG
How to test?
1) Go to the following url : https://jac-admin-develop--pr2603-bugfix-2600-correct-iyu0ze8m.web.app/exercise/MwKzBqbvPyhMZaNXMGP2/dashboard
Ensure 'Exercise Type' displays 'Leadership' instead of 'Strategic Leadership Questions', eg below:
2) Go to the following url: https://jac-admin-develop--pr2603-bugfix-2600-correct-iyu0ze8m.web.app/exercise/MwKzBqbvPyhMZaNXMGP2/applications/draft/application/PAjWsYyeuSkMMLIhUfWO
Ensure the Occupation appears as 'Professional' below instead of 'Professional Assessor' in the Application in Admin
3) Go to the following url: https://jac-admin-develop--pr2603-bugfix-2600-correct-iyu0ze8m.web.app/exercise/MwKzBqbvPyhMZaNXMGP2/applications/draft/application/PAjWsYyeuSkMMLIhUfWO
Ensure the Type appears as 'Professional Assessor' under Independent Assessors in the Application in Admin
4) Go to the following url: https://jac-admin-develop--pr2603-bugfix-2600-correct-iyu0ze8m.web.app/exercise/MwKzBqbvPyhMZaNXMGP2/applications/draft/application/PAjWsYyeuSkMMLIhUfWO
Ensure the Assessor Type appears as 'Professional Assessor' under Independent Assessor Change in the Application in Admin after choosing to edit the Application and choosing to Edit the Independent Assessors
Risk - how likely is this to impact other areas?
🟠 Medium risk - this does change code that is shared with other areas
Related permissions
Have permissions been considered for this functionality?
PREVIEW:DEVELOP
can be OFF, DEVELOP or STAGING