Ticketing System #428 Custom Report NewlIne Chars On Download #2615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomlovesgithub
approved these changes
Nov 26, 2024
|
Visit the preview URL for this PR (updated for commit 7e23461): https://jac-admin-develop--pr2615-bugfix-ts-428-custom-mzq008u1.web.app (expires Thu, 26 Dec 2024 12:51:33 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 4e92cf51659207b0ae3509dc5c40edde50edfec0 |
HalcyonJAC
approved these changes
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's included?
Fixed issue escaping newline chars when downloading the csv file. Previously the newline characters were causing some of the content to appear in the wrong column in the report.
Closes jac-uk/ticketing-system#428
Who should test?
✅ Product owner
✅ Developers
✅ UTG
How to test?
Go to the following url: https://jac-admin-develop--pr2615-bugfix-ts-428-custom-mzq008u1.web.app/exercise/R5mu47EVqEPf1WbXsLfZ/reports/custom
Generate the report with the columns:
... then download the report.
Ensure that no '/n' characters appear in the report and the application referencenNumbers only appear in the left hand column. Generally the report should look fine.
Risk - how likely is this to impact other areas?
🟢 No risk - this is a self-contained piece of work
PREVIEW:DEVELOP
can be OFF, DEVELOP or STAGING