Generated CSV/XLSX sanitisation #2623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Visit the preview URL for this PR (updated for commit 15669a6): https://jac-admin-develop--pr2623-sanitise-xlsx-kc4d6ux1.web.app (expires Thu, 02 Jan 2025 15:34:31 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 4e92cf51659207b0ae3509dc5c40edde50edfec0 |
tomlovesgithub
force-pushed
the
sanitise-xlsx
branch
from
58b0aea to
a611c8e
Compare
tomlovesgithub
temporarily deployed
to
develop
GitHub Actions
Inactive
tomlovesgithub
temporarily deployed
to
develop
GitHub Actions
Inactive
NormaJAC
approved these changes
Nov 27, 2024
tomlovesgithub
temporarily deployed
to
develop
GitHub Actions
Inactive
HalcyonJAC
approved these changes
Dec 3, 2024
drieJAC
approved these changes
Dec 3, 2024
|
@tomlovesgithub might be good to write sone unit tests for this. Should be quite straightforward to run these characters though the helper function to ensure they're correctly escaped. |
tomlovesgithub
temporarily deployed
to
develop
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's included?
Sanitise CSV/XLSX in generated spreadsheet downloads
PREVIEW:DEVELOP
can be OFF, DEVELOP or STAGING