Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/TS 489 Diversity Report Change Calculations #2637

Merged
merged 3 commits into from
Dec 9, 2024

Conversation

HalcyonJAC
Copy link
Contributor

@HalcyonJAC HalcyonJAC commented Dec 9, 2024

What's included?

Related issue: User Raised Issue BR_ADMIN_PR_000268 #489

  • Fix change calculations.

Who should test?

✅ Product owner
✅ Developers

How to test?

Example exercise on Production

Steps:

  1. Go to the Diversity Report of an exercise.
  2. Check if the changes are calculated correctly.

Risk - how likely is this to impact other areas?

🟢 No risk - this is a self-contained piece of work

Additional context

Include screen grabs, video demo, notes etc.

Related permissions

Have permissions been considered for this functionality?

  • No permission changes required
  • Permissions have been added / updated. Details:

PREVIEW:PRODUCTION
can be OFF, DEVELOP or STAGING

Copy link

github-actions bot commented Dec 9, 2024

Visit the preview URL for this PR (updated for commit ac0f454):

https://jac-admin-develop--pr2637-bugfix-ts-489-divers-vwx38qrq.web.app

(expires Wed, 08 Jan 2025 10:47:58 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 4e92cf51659207b0ae3509dc5c40edde50edfec0

Copy link

github-actions bot commented Dec 9, 2024

Visit the preview URL for this PR (updated for commit 216b113):

https://jac-apply-admin-production--pr2637-bugfix-ts-489-diver-44uytrzn.web.app

(expires Wed, 08 Jan 2025 15:09:17 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 2f31b7832d58b04f07d3816f45a5d09d461ded5e

@HalcyonJAC HalcyonJAC marked this pull request as ready for review December 9, 2024 12:39
@HalcyonJAC HalcyonJAC requested review from a team as code owners December 9, 2024 12:39
@nickaddy
Copy link
Contributor

nickaddy commented Dec 9, 2024

@HalcyonJAC Calculations all look good now :-) Just one thing: we don't need the % Change from previous column on the Applied tab. Is it possible to hide that column on the Applied tab only? Make the test white, would that be a quick solution?

@HalcyonJAC
Copy link
Contributor Author

@nickaddy The % Change from previous column has been hidden on the Applied tab. Could you test it again, please?

Copy link
Contributor

@nickaddy nickaddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, @HalcyonJAC thx!

@HalcyonJAC HalcyonJAC merged commit c44e11f into main Dec 9, 2024
6 checks passed
@HalcyonJAC HalcyonJAC deleted the bugfix/ts-489-diversity-report-change-calculations branch December 9, 2024 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants