Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reports for eligibility and character issues #396

Merged
merged 4 commits into from
Apr 21, 2020

Conversation

warrensearle
Copy link
Member

  • Include new reports
  • Amend application back link to use BackLink component

- Include new reports
- Amend application back link to use BackLink component
@warrensearle warrensearle requested a review from YaaL April 20, 2020 16:11
src/filters.js Outdated Show resolved Hide resolved
Copy link
Contributor

@YaaL YaaL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

>
Back
</router-link>
<BackLink />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

</div>

<div
v-for="(issue, index) in application.processing.characterIssues"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor niggle, but it would be nice to have the issues in the same order they appear in the application, not just alphabetically.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorted in back end

@warrensearle warrensearle merged commit 4798c68 into develop Apr 21, 2020
@warrensearle warrensearle deleted the feature/286-eligibility-report branch April 21, 2020 10:58
@warrensearle warrensearle restored the feature/286-eligibility-report branch April 22, 2020 09:14
@warrensearle warrensearle deleted the feature/286-eligibility-report branch April 22, 2020 09:19
@warrensearle warrensearle mentioned this pull request Aug 27, 2020
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants