Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#511 Links to candidate page detail #578

Merged
merged 7 commits into from
Jun 11, 2020
Merged

#511 Links to candidate page detail #578

merged 7 commits into from
Jun 11, 2020

Conversation

lloback
Copy link
Contributor

@lloback lloback commented Jun 11, 2020

This PR deals with links to Candidade Detail page.

The links were added from:

  • from Applications (applicationsFull)

Stages:

  • Review
  • Shortlisted
  • Selected
  • Recommended
  • Handover

@lloback lloback requested a review from warrensearle June 11, 2020 15:15
@lloback lloback linked an issue Jun 11, 2020 that may be closed by this pull request
Ensure when you click the candidate name a page opens with the record #511
Closed
@warrensearle warrensearle changed the title #511 Links to candidadte page detail #511 Links to candidate page detail Jun 11, 2020
warrensearle
warrensearle requested changes Jun 11, 2020
View reviewed changes
Copy link
Member

@warrensearle warrensearle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some of the IDs need changing

src/views/Exercises/Show/ApplicationFull.vue Outdated Show resolved Hide resolved
src/views/Exercises/Stages/HandoverList.vue Outdated Show resolved Hide resolved
warrensearle
warrensearle approved these changes Jun 11, 2020
View reviewed changes
Copy link
Member

@warrensearle warrensearle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@warrensearle warrensearle merged commit 9709637 into develop Jun 11, 2020
@warrensearle warrensearle deleted the feature/511-link-to-candidates branch June 11, 2020 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@warrensearle warrensearle warrensearle approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ensure when you click the candidate name a page opens with the record
2 participants
@lloback @warrensearle