Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#513 Edit Email and Name on the Candidate Detail page #585

Merged
merged 2 commits into from
Jun 13, 2020
Merged

#513 Edit Email and Name on the Candidate Detail page #585

merged 2 commits into from
Jun 13, 2020

Conversation

lloback
Copy link
Contributor

@lloback lloback commented Jun 12, 2020

Added the possibility of editing the name and email directly on the Candidate detail page.

@lloback lloback requested a review from warrensearle June 12, 2020 22:36
warrensearle
warrensearle approved these changes Jun 13, 2020
View reviewed changes
Copy link
Member

@warrensearle warrensearle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works well and is cleverly coded 👍
Please roll this out as is however could you create a follow-on ticket to create a new 'Inline Editor' component where we can define field/editor type and include validation.

@lloback lloback merged commit 2530b85 into develop Jun 13, 2020
@lloback lloback deleted the feature/513-edit-name-email branch June 13, 2020 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@warrensearle warrensearle warrensearle approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lloback @warrensearle