Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant Details.vue #620

Merged
merged 3 commits into from
Jun 19, 2020
Merged

Remove redundant Details.vue #620

merged 3 commits into from
Jun 19, 2020

Conversation

crablab
Copy link
Contributor

@crablab crablab commented Jun 18, 2020

This appeared to be a static template with dummy data. I couldn't see that it was referenced in router.js so I assume it is safe to remove?

I haven't created a ticket, as this is an ad-hoc change.

@crablab crablab requested a review from YaaL June 18, 2020 12:43
@crablab crablab marked this pull request as draft June 18, 2020 12:56
@crablab crablab marked this pull request as ready for review June 18, 2020 12:59
@lloback
Copy link
Contributor

lloback commented Jun 18, 2020

I think it is best practice to create a ticket - we need to discuss with @warrensearle and @YaaL how do we want to handle, maybe calling TECH TASK: delete unusued files or something like that, and not sending it to @Rebecca-mcknight1991 or @ClaireTroughtonJAC to test. We need to test it ourselves.

This particular PR, I will leave it to @warrensearle or @YaaL to review.

Copy link
Member

@warrensearle warrensearle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, this can go now. There are other redundant files too. We have an upcoming epic to review and tidy the code base so this PR could reference that issue #496

@crablab
Copy link
Contributor Author

crablab commented Jun 19, 2020

I think it is best practice to create a ticket

Agreed - that makes sense.

There are other redundant files too. We have an upcoming epic to review and tidy the code base so this PR could reference that issue

I've added this to that Epic, and I'll add a specific ticket in that Epic to remove redundant files 👍

@crablab crablab linked an issue Jun 19, 2020 that may be closed by this pull request
@crablab crablab merged commit 5ca232a into develop Jun 19, 2020
@crablab crablab deleted the remove-redundant-file branch June 19, 2020 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove redundant Details.vue
3 participants