Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add logic for active page highlighting #623

Merged
merged 7 commits into from
Jun 26, 2020
Merged

Add logic for active page highlighting #623

merged 7 commits into from
Jun 26, 2020

Conversation

tomlovesgithub
Copy link
Contributor

navigation now highlights active pages correctly

@tomlovesgithub tomlovesgithub added this to the 20JUNB milestone Jun 19, 2020
warrensearle
warrensearle approved these changes Jun 26, 2020
View reviewed changes
Copy link
Member

@warrensearle warrensearle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works 👍
I suspect we can look at this.$route.params instead of this.$route.path for some of the checks in isActive method. Let's do that in the next iteration.

@warrensearle warrensearle merged commit a491b2a into develop Jun 26, 2020
@warrensearle warrensearle deleted the feature/564-Navbar-Issues branch June 26, 2020 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@warrensearle warrensearle warrensearle approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
20JUNB
Development

Successfully merging this pull request may close these issues.
2 participants
@tomlovesgithub @warrensearle