footer inserted #685
Merged
footer inserted #685
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
warrensearle
approved these changes
Jul 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For an initialism which begins with scaleable, i had some real difficulty getting the SVG to adhere to the desired proportions.
However i managed to get there in the end.
I have also made some changes to the formatting of the template in the App.vue, so now the template's single child contains only three elements; header, main, and footer. This was done in order to allow the footer to fill the full width of the screen, as shown in the prototype.
I have currently disabled all content within the footer, as i'd like some assurance that at JAC we are indeed offering 'All content is available under the Open Government Licence v3.0, except where otherwise stated' as the footer text suggests