Feature/#704 add copy to clipboard button in application view #708
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please excuse the atrocity above, i tried to squash a commit with |
tomlovesgithub
force-pushed
the
feature/#704-Add-Copy-to-clipboard-button-in-application-view
branch
from
0cb4a56 to
6e5b017
Compare
warrensearle
approved these changes
Jul 30, 2020
warrensearle
approved these changes
Jul 31, 2020
There was a problem hiding this comment.
Awesome 👍
Let's see how useful this is. @tomlovesgithub can you get this properly user tested by the ops team?
YaaL
suggested changes
Jul 31, 2020
…n-view' of https://github.com/jac-uk/admin into feature/#704-Add-Copy-to-clipboard-button-in-application-view
tomlovesgithub
deleted the
feature/#704-Add-Copy-to-clipboard-button-in-application-view
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-Did play around with positioning of button, needs either to be outside of tabs area (like pdf and doc buttons), so that the button remains visible when tabs are clicked or inside each tab.