Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#711 - Identifies late IAs in admin #727

Merged
merged 6 commits into from
Aug 4, 2020
Merged

Conversation

crablab
Copy link
Contributor

@crablab crablab commented Aug 3, 2020

Helper functionality:

  • New isDateGreaterThan date helper with tests
  • 'Borrowed' the assessment store with modification to allow updating single assessment record
  • Register assessment in store.js

Functionality:

  • Running late IAs (ie. those not submitted but past due date) show as LATE
  • Submitted late IAs (ie. those submitted past due date) show as LATE
  • Needing approval IAs (ie. those submitted past due date) have download button hidden and an approval button shown/
  • Allows approval for late IAs to be approved (which allows them to be downloaded)

Rejection for late IAs is implicit (can be changed - ticket isn't clear on this)

screenshot_2020-08-03-155509

crablab added 4 commits August 3, 2020 11:51
- Running late IAs (ie. those not submitted but past due date)
- Submitted late IAs (ie. those submitted past due date)
- Needing approval IAs (ie. those submitted past due date)
- Allows approval for late IAs to be approved (which allows them to be downloaded)

Rejecttion for late IAs is implicit
@crablab crablab requested review from YaaL and warrensearle August 3, 2020 14:54
@crablab
Copy link
Contributor Author

crablab commented Aug 3, 2020

@ClaireTroughtonJAC Please could you confirm if the Approve late submission button should be two separate approve/reject buttons, and if any copy change needed 😄

Thanks!

@crablab
Copy link
Contributor Author

crablab commented Aug 4, 2020

As discussed at standup, Claire is happy with this approach and the logic. We've discussed a separate reject button, but we feel rejection is implicit here. We also discussed disabling the approval button after the hard limit, but this isn't ideal if IAs are processed subsequently.

@warrensearle to review 😄

Copy link
Member

@warrensearle warrensearle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work 👍

@crablab crablab merged commit df778f6 into develop Aug 4, 2020
@crablab crablab deleted the feature/711-show-late-ias branch August 4, 2020 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants