#860 Fix DateInput component not allowing datetime #861
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@lloback and @tomlovesgithub I have merged this into develop as it's needed for tomorrow's Qualifying Test dry run however please do both review this change. |
lloback
reviewed
Sep 17, 2020
| @@ -219,7 +218,7 @@ export default { | |||
| if (this.dateConstructor === null) { | |||
| return null; | |||
| } else { | |||
| return new Date(Date.UTC(...this.dateConstructor)); | |||
| return new Date(...this.dateConstructor); | |||
There was a problem hiding this comment.
I have changed this to UTC because we were having issues with 29/03/2020 which is the date that GMT becomes BST. WE need to test this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes again the
Date.UTCcall that was initially removed in #831 but added back in #848.Instead I have changed the default time to 13:00. Partly because JAC tends to use 13:00 as default time for launching an exercise, for example... But mainly because this means we bypass the BST daylight saving issue that was being experienced where a default time of 0:00 was (when in BST) being converted to 23:00 the previous day.