Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

884/view scenario test #889

Merged
merged 9 commits into from
Sep 23, 2020
Merged

884/view scenario test #889

merged 9 commits into from
Sep 23, 2020

Conversation

tomlovesgithub
Copy link
Contributor

@tomlovesgithub tomlovesgithub commented Sep 22, 2020

cant connect to issues cause i dont have zenhub chrome plugin on this laptop - sorry!!

Theses views have been built assuming the following JSON structure which is based on this firestore entry

...
testQuestions: {
  introduction: "I am introductory instruction text",
    questions: [
       0: {
        details: "I am the scenario to work through",
        questions: [
                   0: {answer: "Question 1", limit: 100},
                   ...
       },
          ...
     ],
        responses: [
                   0: {text: "I am the text the candidate entered", count: 50, started: datetime, completed: datetime}
                   1: {text: null, count: 0, started: datetime, completed: datetime} // Null indicates skipped question
        ]
  }
 }
...

I have some concerns over where this.qualifyingTest.testQuestions.questions[i].questions[i].options[i].text is used as i wasn't sure weather this value should rather come from the response object.
I have come to the conclusion that it should be okay as its on the responses page, where the XLSX is built so has access to both objects, just threw me a little.
All the same i am a unsure of weather i have interpreted the data objects incorrectly with the header titling on responses page line 97 (will highlight on PR)

Some of the response objects don't have the element.application.referenceNumber I'm assuming this is a development issue rather than a legacy thing, so my solution doesn't care that this doesn't exist, may error on staging/dev if not downloading the correctly formatted data.

Im using v-html, i got some warnings and noticed that eslint has been disabled else where it is used.

// headers.push('scenario');
// }
if (this.qualifyingTest.type === QUALIFYING_TEST.TYPE.SCENARIO) {
question.options.forEach((option, decimal) => {
Copy link
Contributor Author

@tomlovesgithub tomlovesgithub Sep 22, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unsure about these :? (line 97 see PR description)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No worries, I fixed it.

  • decimal is the index

@lloback lloback merged commit ae859e4 into develop Sep 23, 2020
@lloback lloback deleted the 884/view-scenario-test branch September 23, 2020 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants