-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
884/view scenario test #889
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomlovesgithub
commented
Sep 22, 2020
// headers.push('scenario'); | ||
// } | ||
if (this.qualifyingTest.type === QUALIFYING_TEST.TYPE.SCENARIO) { | ||
question.options.forEach((option, decimal) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
unsure about these :? (line 97 see PR description)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No worries, I fixed it.
- decimal is the
index
lloback
approved these changes
Sep 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cant connect to issues cause i dont have zenhub chrome plugin on this laptop - sorry!!
Theses views have been built assuming the following JSON structure which is based on this firestore entry
I have some concerns over where
this.qualifyingTest.testQuestions.questions[i].questions[i].options[i].text
is used as i wasn't sure weather this value should rather come from the response object.I have come to the conclusion that it should be okay as its on the responses page, where the XLSX is built so has access to both objects, just threw me a little.
All the same i am a unsure of weather i have interpreted the data objects incorrectly with the header titling on responses page line 97 (will highlight on PR)
Some of the response objects don't have the
element.application.referenceNumber
I'm assuming this is a development issue rather than a legacy thing, so my solution doesn't care that this doesn't exist, may error on staging/dev if not downloading the correctly formatted data.Im using v-html, i got some warnings and noticed that eslint has been disabled else where it is used.