Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix reference number in qt score download #907

Merged
merged 2 commits into from
Sep 29, 2020

Conversation

tomlovesgithub
Copy link
Contributor

Ref num for QT downloads is sometimes missing and when working on a feature i hardcoded it to a string, ive now added a fallback default empty string which will show when the field isn't present and the same thing for the fullName field which will default to the name field

Copy link
Member

@warrensearle warrensearle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@warrensearle warrensearle changed the title Fix refference number in qt score download Fix reference number in qt score download Sep 28, 2020
@tomlovesgithub tomlovesgithub merged commit 7c53656 into develop Sep 29, 2020
@tomlovesgithub tomlovesgithub deleted the fix-refference-number-in-qt-score-download branch September 29, 2020 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants