Bugfix/TS 496 Self assessment extraction word counts #1275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Visit the preview URL for this PR (updated for commit 6a2d6f1): https://jac-apply-develop--pr1275-bugfix-ts-496-self-a-whdn4fy1.web.app (expires Sun, 02 Feb 2025 11:05:31 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: d5ac0a9c931657844a433a502135cf38aca21627 |
HalcyonJAC
requested review from
NormaJAC,
tomlovesgithub,
drieJAC,
KoWeiJAC,
warrensearle,
nickaddy and
Franceswog
drieJAC
approved these changes
Dec 18, 2024
|
@HalcyonJAC For me, they are counting differently:
|
|
@nickaddy It only works for |
|
@HalcyonJAC Yes, pls. I thought I had the same ones, I couldn't find another. On a PC, the key to the left of 1 at the top of the keyboard and on the button with @. Where is the other one? |
|
@nickaddy Could you test it again, please? |
NormaJAC
approved these changes
Dec 20, 2024
tomlovesgithub
approved these changes
Dec 23, 2024
…d-counts # Conflicts: # package-lock.json # package.json
HalcyonJAC
deleted the
bugfix/ts-496-self-assessment-extraction-word-counts
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's included?
Issue: User Raised Issue BR_ADMIN_PR_000274 #496
4.1.53.splitWordsfrom jac-kit in theFormFieldcomponent.Who should test?
✅ Product owner
✅ Developers
How to test?
Example vacancy
Steps:
Apply for the vacancy and go to the "Self assessment with competencies" section.
Upload a finished self assessment and check if the word count is correct.
For example, the word count for
It’s something aboutandIt's something aboutshould be 3.Risk - how likely is this to impact other areas?
🟢 No risk - this is a self-contained piece of work
Additional context
Demo:
Screen.Recording.2024-12-18.at.09.49.57.mov
PREVIEW:DEVELOP
can be OFF, DEVELOP or STAGING