-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Admin # 1271 Show RTF for ASC questions #767
Conversation
Visit the preview URL for this PR (updated for commit 500fa64): https://apply-prod--pr767-admin-1271-rtf-for-a-ta2q53m2.web.app (expires Thu, 29 Jul 2021 16:18:11 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and works as expected ✅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
StatementOfSuitability.vue and SelfAssessmentCompetencies.vue also need to be updated.
This gets an approval from me. However I just need to sling this one to the User Testing Group and when I receive feedback i'll come back in to approve for deployment to production. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After some patchy testing via UTG, I have sent this to the non-legal team who will be using this feature most.
They will be adding feedback in this Slack channel by the end of the week, so if you need to deploy this in my abscence, please check there first. The team members testing are Sam Marzan-Esher and Lauren Yu.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 looks fine to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @tomlovesgithub, I have received feedback from the UTG that if the content entered into the Admin ASC free-text field is changed after launch, this is not updated for applications in 'draft' and the changes will only appear for those who are yet to start an application.
Is it possible to ensure that any edits applied to the Admin ASC free text field after launch, be globally applied to applications in draft on Apply, in addition to those applications now yet started?
Sent to UTG today for re-testing after changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Positive results at UTG
What's included?
Rich text display of ASC details.
Who should test?
✅ Product owner
✅ Developers
✅ UTG
How to test?
Ensure Rich text is displayed to candidates when viewing ASC questions. - See screen below
Risk - how likely is this to impact other areas?
🟠 Medium risk - Here we are using v-html to manipulate the DOM directly, we are doing this elsewhere but its worth noting.
Additional context
PREVIEW:OFF
can be OFF, DEVELOP or STAGING