Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Admin # 1271 Show RTF for ASC questions #767

Merged
merged 5 commits into from
Jun 29, 2021
Merged

Conversation

tomlovesgithub
Copy link
Contributor

@tomlovesgithub tomlovesgithub commented Apr 23, 2021

What's included?

Rich text display of ASC details.

Who should test?

✅ Product owner
✅ Developers
✅ UTG

How to test?

Ensure Rich text is displayed to candidates when viewing ASC questions. - See screen below

Risk - how likely is this to impact other areas?

🟠 Medium risk - Here we are using v-html to manipulate the DOM directly, we are doing this elsewhere but its worth noting.

Additional context

image


PREVIEW:OFF
can be OFF, DEVELOP or STAGING

@tomlovesgithub tomlovesgithub requested review from a team as code owners April 23, 2021 15:28
@tomlovesgithub tomlovesgithub requested review from lloback, HalcyonJAC, mbrookeswebdev and KateMJAC and removed request for a team April 23, 2021 15:28
@github-actions
Copy link

github-actions bot commented Apr 23, 2021

Visit the preview URL for this PR (updated for commit 500fa64):

https://apply-prod--pr767-admin-1271-rtf-for-a-ta2q53m2.web.app

(expires Thu, 29 Jul 2021 16:18:11 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

@warrensearle warrensearle requested review from warrensearle and removed request for lloback April 26, 2021 10:08
Copy link
Member

@warrensearle warrensearle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works as expected ✅

Copy link
Contributor

@mbrookeswebdev mbrookeswebdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can see HTML tags instead of formatted text:

Statement-of-suitability-Judicial-Appointments-Commission

Self-assessment-competencies-Judicial-Appointments-Commission

Copy link
Contributor

@mbrookeswebdev mbrookeswebdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

StatementOfSuitability.vue and SelfAssessmentCompetencies.vue also need to be updated.

@KateMJAC
Copy link

This gets an approval from me. However I just need to sling this one to the User Testing Group and when I receive feedback i'll come back in to approve for deployment to production.

Copy link

@KateMJAC KateMJAC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After some patchy testing via UTG, I have sent this to the non-legal team who will be using this feature most.

They will be adding feedback in this Slack channel by the end of the week, so if you need to deploy this in my abscence, please check there first. The team members testing are Sam Marzan-Esher and Lauren Yu.

Copy link
Contributor

@HalcyonJAC HalcyonJAC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 looks fine to me.

Copy link

@KateMJAC KateMJAC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @tomlovesgithub, I have received feedback from the UTG that if the content entered into the Admin ASC free-text field is changed after launch, this is not updated for applications in 'draft' and the changes will only appear for those who are yet to start an application.

Is it possible to ensure that any edits applied to the Admin ASC free text field after launch, be globally applied to applications in draft on Apply, in addition to those applications now yet started?

@warrensearle warrensearle temporarily deployed to develop May 19, 2021 15:48 Inactive
@tomlovesgithub tomlovesgithub temporarily deployed to develop June 2, 2021 13:07 Inactive
@tomlovesgithub tomlovesgithub requested a review from KateMJAC June 2, 2021 16:12
@tomlovesgithub tomlovesgithub dismissed KateMJAC’s stale review June 22, 2021 13:44

Should be fixed!

@KateMJAC
Copy link

Sent to UTG today for re-testing after changes.

@tomlovesgithub tomlovesgithub temporarily deployed to production June 29, 2021 16:14 Inactive
Copy link

@KateMJAC KateMJAC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Positive results at UTG

@tomlovesgithub tomlovesgithub merged commit d51efd5 into main Jun 29, 2021
@tomlovesgithub tomlovesgithub deleted the admin#1271/rtf-for-ASC branch June 29, 2021 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants