Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply Proper Fix For Changing Lord Chief Justice To Lady Chief Justice #963

Open
drieJAC opened this issue Nov 6, 2023 · 0 comments
Open

Comments

@drieJAC
Copy link
Contributor

drieJAC commented Nov 6, 2023

A request came in to change 'Lord Chief Justice' to 'Lady Chief Justice'.
The following PRs were created and are now live to achieve this:

#962
jac-uk/admin#2214
jac-uk/apply#1104

Some of the code was an urgent fix and it mapped 'lord' to 'lady' chief justice in the lookups (filters).
Ultimately though we should:

  • remove that mapping of 'lord' to 'lady' chief justice
  • update db records to change 'lord' to 'lady' chief justice in exercise.appropriateAuthority (array)

Note that @warrensearle wanted to quiz @nickaddy on whether there were any knock-on effects from making this original change with respect to legacy data and also judge titles being listed next to their names, ie an exercise from 2 years ago may have a 'Lord Chief Justice' with a male name which will now appears next to 'Lady Chief Justice'.

Just noticed that there is an existing issue on the platform as a result of this original hotfix. See screenshot below:

Screenshot 2023-11-12 at 21 39 14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant