DownloadLink checks Checksum, FileUpload displays Limit #213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomlovesgithub
changed the title
HalcyonJAC
reviewed
Aug 16, 2024
tomlovesgithub
requested review from
warrensearle,
HalcyonJAC,
drieJAC,
KoWeiJAC and
a team
5 tasks
KoWeiJAC
approved these changes
Aug 27, 2024
drieJAC
approved these changes
Aug 30, 2024
HalcyonJAC
approved these changes
Sep 13, 2024
warrensearle
approved these changes
Sep 13, 2024
Comment on lines
+56
to
+58
| ...mapGetters({ | ||
| checksumsEnabled: 'candidateSettings/getUploadStatus', // Get checksumsEnabled from Vuex store | ||
| }), |
There was a problem hiding this comment.
This component probably shouldn't access the store directly but instead have a checksumsEnabled prop fed into it...
However if that would be a headache to roll out everywhere this component is used then let's stick with the current approach which nicely keeps everything in one place (just means we need the same store to exist in our apps that use this component) 🤓
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FileUpload component now displays the accepted types and file size limit, as well as preventing uploads when the scanner status is offline.
I have also amended the way these props are accepted and used.
DownloadLink is now ready for checksums, altho there is a bypass which means that this component can be rolled out prior to checksum creation (thanks for the idea @warrensearle).