Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

for support ascvrq #62

Merged
merged 54 commits into from
Jun 6, 2024
Merged

for support ascvrq #62

merged 54 commits into from
Jun 6, 2024

Conversation

xymyeah
Copy link
Collaborator

@xymyeah xymyeah commented Mar 26, 2024

PR types

PR changes

Describe

xymyeah added 29 commits March 22, 2024 17:37
YaoCheng8667 pushed a commit to YaoCheng8667/Paddle that referenced this pull request Apr 25, 2024
xymyeah and others added 20 commits April 28, 2024 17:56
@@ -1130,8 +1154,8 @@ void BoxPSWorker::CreateThreadScopeForSharding(const ProgramDesc& program) {
++copy_persist_num;
// device 0 need sync datanorm and learning rate to root scope
if (device_id_ == 0) {
need_copy_vars_.push_back(name);
skip_vars_.push_back(name);
need_copy_vars_.push_back(name);
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里缩进应该是2个空格?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

"contains uninitialized Tensor.",
Type(),
name));
PADDLE_ENFORCE_EQ(
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

缩进错了,一般是2格,换行是4格

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@@ -133,6 +133,9 @@ class ThreadPool {
}
// VLOG(0) << "binding read ins thread_id = " << tid << ", cpunum = " <<
}
int GetThreadNum(void) {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

缩进2个空格

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@xymyeah xymyeah requested a review from jack603047588 June 6, 2024 02:25
@xymyeah xymyeah merged commit 783db57 into jack603047588:paddlebox Jun 6, 2024
@xymyeah xymyeah deleted the support_ascvrq branch June 6, 2024 02:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants