-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
for support ascvrq #62
for support ascvrq #62
Conversation
add hbm garbage gc
@@ -1130,8 +1154,8 @@ void BoxPSWorker::CreateThreadScopeForSharding(const ProgramDesc& program) { | |||
++copy_persist_num; | |||
// device 0 need sync datanorm and learning rate to root scope | |||
if (device_id_ == 0) { | |||
need_copy_vars_.push_back(name); | |||
skip_vars_.push_back(name); | |||
need_copy_vars_.push_back(name); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这里缩进应该是2个空格?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
paddle/fluid/framework/operator.cc
Outdated
"contains uninitialized Tensor.", | ||
Type(), | ||
name)); | ||
PADDLE_ENFORCE_EQ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
缩进错了,一般是2格,换行是4格
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
paddle/fluid/framework/threadpool.h
Outdated
@@ -133,6 +133,9 @@ class ThreadPool { | |||
} | |||
// VLOG(0) << "binding read ins thread_id = " << tid << ", cpunum = " << | |||
} | |||
int GetThreadNum(void) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
缩进2个空格
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
PR types
PR changes
Describe