Unset nodeIdentifier on Delete

[wjzijderveld]

I am not completely sure this is an actual bug and if so, if this is the correct fix. But it works for me ;-)

The bug I ran into can be reproduced like this:

1. Use an existing workspace
2. Delete a node from it (that has a jcr:uuid)
3. $session->save()
4. Recreate the node with a new reference
5. $session->save()
6. Use that node as reference for another (new) node

You will now get an PHPCR\ReferentialIntegrityException, stating that the reference you gave the does not exist.
That failed because Client.php holds an internal list of UUID's and found the UUID for the deleted Node there.

[dbu]

seems sane. could you maybe add a test to phpcr-api-tests that demonstrates the bug? by "recreate" you mean create it at the same path?

[wjzijderveld]

Yeah, I meant recreating at the same path. In this case I was recreating some example nodes, so deleted them before creating them again.

Busy with the test right now.

[wjzijderveld]

It seems I forgot to add the referenceable mixin...
Probably still a bug but with the wrong Exception?
I'll look into it later..

[dbu]

yeah trying to create a reference on a node without that mixin is not allowed and should trigger an error immediately. surprised it does not already.

if you have the mixin, all works as expected?

[wjzijderveld]

Yes, then it works like expected. I'll try to look at the error this
evening (as well as at the still open #156)

[dbu]

@wjzijderveld any chance you manage to fix this in the next couple of days so we can have it in 1.1.0?

[wjzijderveld]

I'll try, I had a vacation the last 10 days so I'm spending most of my
time with my wife and less time behind my computer.
Hoping to pick those up again in the next few days, but not sure if I
can create enough time to fix them.

[wjzijderveld]

Added the test to phpcr-api-tests and rebased on master.

[wjzijderveld]

IMO this PR can be merged as soon as phpcr/phpcr-api-tests#122 is merged.
I could replicate the issue even with the mixin, not sure what I did wrong then.

[dbu]

i merged the test and retriggered the build, lets see.

[dbu]

thanks!