XMLCodec: fix DecodeValue to return a []byte #2228
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, DecodeValue would always return nil with the default Unmarshal function. fixes #2227
jackc
force-pushed
the
fix-xml-decode-value
branch
from
6e4f2eb to
329cb45
Compare
|
While this does fix this specific issue, it no longer respects a custom |
This preserves backwards compatibility in the unlikely event someone is using an alternative XML unmarshaler that does support unmarshalling into *any.
|
@felix-roehrich It does seem very unlikely... but I suppose the fix could be implemented in the default |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, DecodeValue would always return nil with the default Unmarshal function.
fixes #2227