Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

isValidNumber now returns null value when utils script is not available #364

Merged
merged 1 commit into from
Feb 12, 2016

Conversation

slavafomin
Copy link
Contributor

Fixes #362.

jackocnr added a commit that referenced this pull request Feb 12, 2016
isValidNumber now returns null value when utils script is not available
@jackocnr jackocnr merged commit ada0192 into jackocnr:master Feb 12, 2016
@jackocnr
Copy link
Owner

Thanks!

@slavafomin
Copy link
Contributor Author

My pleasure. Will you be able to release this change in the new version soon? 7.1.2 I believe.

@jackocnr
Copy link
Owner

Actually v8.0.1. Done.

@slavafomin
Copy link
Contributor Author

Oh, I would really want to use autoFormat feature. This is probably the most important thing in the whole library for us. It works pretty great with international phone numbers in our locality. Are you planning to completely drop support for this feature?

I'm going to stick with the 7.x branch for now then. Could you please merge this change into this branch as well?

@jackocnr
Copy link
Owner

I feel your pain, but unfortunately I had to remove autoFormat because it is fundamentally broken for 49 countries including USA. See a full list here: #346 (comment). If you want your site to work for people from those countries, then you shouldn't use autoFormat.

If you still choose to, you can continue to use v7 of the plugin, but I will not be maintaining it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants