Revert "Use DisableLookback feature in NodeReplacer" #304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit c2454bb. in #223 the objective was to avoid querying excessive amounts of previous data (e.g. double lookback range). This particular change actually made it so we are now significantly more strict about the timestamps that we get from the downstream; which is not as desierable (as any level of caching in the middle causes issues). What this does mean though is if the result returns an inaccurate timestamp (due to caching or something else) promql may interpolate the value -- which is what it does for all other queries of data off of the scrape interval. So this should be fine -- and was the previous behavior. Fixes #298
With this option we can configure promql to not select previous points on certain VectorSelectors when iterating. This is important as we have pulled the data from another promql interface and as such don't want to re-do the full LookbackDelta when selecting within the vector. Fixes #298
|
I confirmed it works! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit c2454bb.
in #223 the objective was to avoid querying excessive amounts of
previous data (e.g. double lookback range). This particular change
actually made it so we are now significantly more strict about the
timestamps that we get from the downstream; which is not as desierable
(as any level of caching in the middle causes issues). What this does
mean though is if the result returns an inaccurate timestamp (due to
caching or something else) promql may interpolate the value -- which is
what it does for all other queries of data off of the scrape interval.
So this should be fine -- and was the previous behavior.
Fixes #298