Set RemoteReadConcurrencyLimit to fix /api/v1/read #351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously this value was unset, defaulting to zero. A zero-value initialised a channel with no buffer, causing all writes to the buffer to hang, and therefore all remote_read queries to hang until they timed-out. This is contradictory to the Prometheus documentation, which claims that a zero value allows infinite concurrent reads. Fixes: jacksontj#350 Signed-off-by: Joe Groocock <jgroocock@cloudflare.com>
jacksontj
approved these changes
Oct 6, 2020
|
Thanks for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously this value was unset, defaulting to zero. A zero-value
initialised a channel with no buffer, causing all writes to the buffer
to hang, and therefore all remote_read queries to hang until they
timed-out. This is contradictory to the Prometheus documentation, which
claims that a zero value allows infinite concurrent reads.
Related: https://github.com/prometheus/prometheus/pull/4656/files
Fixes: #350
Signed-off-by: Joe Groocock jgroocock@cloudflare.com