Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-sort sort function returns in NodeReplacer #492

Merged
merged 1 commit into from
Feb 3, 2022
Merged

Re-sort sort function returns in NodeReplacer #492

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions pkg/proxystorage/proxy.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -513,6 +513,16 @@ func (p *ProxyStorage) NodeReplacer(ctx context.Context, s *parser.EvalStmt, nod
n.Args[0] = ret
return nil, nil
}

// the functions of sort() and sort_desc() need whole results to calculate.
switch n.Func.Name {
case "sort", "sort_desc":
return &parser.Call{
Func: n.Func,
Args: []parser.Expr{ret},
}, nil
}

return ret, nil

// If we are simply fetching a Vector then we can fetch the data using the same step that
Expand Down