Added corresponding key for ingress kind in Helm values #509
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR; this seems like a good addition. I'm trying to get github to run the tests; seems that the close/re-open triggered the test. After running there was an issue with CI -- I have since fixed that, but I'll need you to rebase this PR to get it to pass :( Once that is done I can merge, thanks! |
hayk96
force-pushed
the
fix-helm-chart-ingress
branch
from
32edebb to
f57f4cb
Compare
Done! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following error receiving while installing via Helm
Error: template: promxy/templates/ingress.yaml:1:14: executing "promxy/templates/ingress.yaml" at <.Values.ingress.enabled>: nil pointer evaluating interface {}.enabledWhat this PR does / why we need it:
This PR is about fixing Helm values related to ingress.