Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't pass down times if we weren't given one #575

Merged
merged 3 commits into from
Mar 22, 2023
Merged

Don't pass down times if we weren't given one #575

merged 3 commits into from
Mar 22, 2023

Conversation

jacksontj
Copy link
Owner

@jacksontj jacksontj commented Mar 22, 2023 •
edited
Loading

  • Update the client_golang to latest main -- which will not send optional times if they are time.Time{} (zero time)
  • Change base API client wrapper to clear time if it is equal to min/max time
  • Move debug wrapping to be at the end of the chain

@jacksontj
Update prometheus client_golang to latest main
c75fecc
@jacksontj
If the start/end times are the min/max times, don't set
89f033b 
This will (with the new upstream client change) not send the start/end
to the downstream API

Fixes #528
@jacksontj
Move debug wrap to right-before the API client
871cf57 
This way other client changes are captured in the debug logging

NOTE: this does not capture changes within the last API client (e.g.
time removal for min/max time)
@jacksontj jacksontj merged commit 012690f into master Mar 22, 2023
@jacksontj jacksontj deleted the issue_528 branch March 22, 2023 16:40
@jacksontj jacksontj mentioned this pull request Mar 24, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jacksontj