Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code improvement #109

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

Martinski4GitHub
Copy link
Contributor

Removed/modified code related to "var $j = jQuery.noConflict();" which is now considered obsolete.

Removed/modified code related to "var $j = jQuery.noConflict();" which is now considered obsolete.
@jackyaz
Copy link
Owner

jackyaz commented Aug 22, 2024

this was needed on older firmwares due to old jquery. does this affect minimum version support?

@Martinski4GitHub
Copy link
Contributor Author

Martinski4GitHub commented Aug 23, 2024

this was needed on older firmwares due to old jquery. does this affect minimum version support?

Sorry, I don't really understand the question about "minimum version support" WRT jQuery.

My current understanding is as follows. According to dave14305, the changes related to the line "var $j=jQuery.noConflict();" were made to ensure compatibility & avoid conflicts with John's forked F/W builds. However, John (aka john9527) has essentially stopped the development of his fork. The last official release was issued on 2021-Dec-19, and the last Development-Beta release was issued on 2022-Aug-03. So for all intents and purposes, John's fork has been abandoned for at least 2 years now, and no one else is stepping up to take his place. So the current recommendation is to remove those "$j" changes since they are now considered obsolete and are starting to cause some issues with the latest RMerlin F/W builds.

I hope this helps to provide more context.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants