Code Improvements #66
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1) Added code to check if sufficient JFFS storage space is available before moving database files/folders from USB location to JFFS partition. An error message is reported if not enough space is available, and the move request is aborted. The storage check reserves 10MB of space so that JFFS partition has sufficient space left to work with the router after moving the database files/folders over. 2) Added code to check if available JFFS storage space falls below 20% of total space or 10MB (whichever is lower) and report an error when it does. A warning message is also shown on the SSH CLI menu and WebGUI page. 3) Added "export PATH" statement to make the built-in binaries have higher priority than the equivalent Entware binaries. 4) Various code improvements & fine-tuning.
Addressing Codacy Static Code Analysis errors.
Addressing Codacy Static Code Analysis checks.
Addressing Codacy Static Code Analysis checks.
Addressing Codacy Static Code Analysis checks.
|
This latest PR includes improvements & checks to help users who at some point attempt to change the current "Storage Location" from USB to JFFS to make sure that there's enough available free space to hold all the database-related files & folders. Example screenshot when the currently available JFFS storage space looks good:
Example screenshots when the currently available JFFS storage space falls below the minimum reserved space
|
Added and modified code so that every time the SSH CLI menu is run, it checks if the WebGUI page has already been mounted. If not found mounted, the script will run the code to remount the WebGUI.
Updated.
Improved code that creates (during installation) and removes (during uninstallation) the "AddOns" menu tab entry for the WebGUI to make sure it checks for and takes into account other add-ons that may have been installed before or were later installed after the initial installation.
Fine-tuning code.
Some code improvements & fine-tuning.
Improvements & Fine-Tuning
Minor code improvements.
|
Let me know if you have any questions or concerns about the latest changes in this PR. Thanks. |
Shellcheck codes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added code to check if sufficient JFFS storage space is available before moving database files/folders from USB location to JFFS partition. An error message is reported if not enough space is available, and the move request is aborted.
Added code to check if available JFFS storage space falls below 20% of total space or 10MB (whichever is lower) and report a warning when it does. A warning message is also shown on the SSH CLI menu and WebGUI page.
Added and modified code so that every time the SSH CLI menu is run, it checks if the WebGUI page has already been mounted. If not found mounted, the script will run the code to remount the WebGUI.
Improved code that creates (during installation) and removes (during uninstallation) the "AddOns" menu tab entry for the WebGUI to make sure it checks for and takes into account other add-ons that may have been installed before or were later installed after the initial installation.
Added "export PATH" statement to give the built-in binaries higher priority than the equivalent Entware binaries.
Various code improvements & fine-tuning.